Skip to content

Comments

Remove column reconstruction when processing rpc requests#8051

Merged
mergify[bot] merged 4 commits intosigp:unstablefrom
eserilev:delete-reconstruction-over-rpc
Sep 16, 2025
Merged

Remove column reconstruction when processing rpc requests#8051
mergify[bot] merged 4 commits intosigp:unstablefrom
eserilev:delete-reconstruction-over-rpc

Conversation

@eserilev
Copy link
Member

Prevent the node from attempting to reconstruct data columns during RPC request processing. Instead allow sync to send out requests to fetch missing columns. Reconstruction is a computationally expensive task, especially at higher blob counts and should be avoided when possible.

@eserilev eserilev requested a review from jxs as a code owner September 16, 2025 02:05
@eserilev eserilev added das Data Availability Sampling ready-for-review The code is ready for review labels Sep 16, 2025
@mergify
Copy link

mergify bot commented Sep 16, 2025

Some required checks have failed. Could you please take a look @eserilev? 🙏

@mergify mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Sep 16, 2025
@eserilev eserilev added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Sep 16, 2025
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Sep 16, 2025
mergify bot added a commit that referenced this pull request Sep 16, 2025
jimmygchen added a commit to jimmygchen/lighthouse that referenced this pull request Sep 16, 2025
commit a209f72
Author: Eitan Seri- Levi <eserilev@gmail.com>
Date:   Mon Sep 15 20:18:40 2025 -0700

    remove publish flag

commit a4044a9
Author: Eitan Seri- Levi <eserilev@gmail.com>
Date:   Mon Sep 15 20:14:34 2025 -0700

    remove publish flag

commit eab7693
Author: Eitan Seri- Levi <eserilev@gmail.com>
Date:   Mon Sep 15 18:56:19 2025 -0700

    linting

commit a3e0aec
Author: Eitan Seri- Levi <eserilev@gmail.com>
Date:   Mon Sep 15 18:53:23 2025 -0700

    Delete reconstruction when processesing column rpc requests
@mergify mergify bot merged commit 4409500 into sigp:unstable Sep 16, 2025
37 checks passed
jtraglia pushed a commit to jtraglia/lighthouse that referenced this pull request Sep 16, 2025
Co-Authored-By: Eitan Seri- Levi <eserilev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

das Data Availability Sampling ready-for-merge This PR is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants